From: Bron Gondwana (no email)
Date: Thu Sep 20 2007 - 21:50:45 EDT
On Thu, 20 Sep 2007 10:56:59 +0100 (BST), "David Carter" <> said:
> On Thu, 20 Sep 2007, Bron Gondwana wrote:
>
> > Actually, I'm not 100% sure that it's the only way to do things, but it
> > was not particularly invasive and a small extra amount of CPU time and
> > memory copying in exchange for a large saving on replica IO has made our
> > servers a lot happier about users with big mailboxes being moved!
>
> Definitely an improvement over the repeatupload stuff. It would make
> sense
> for upload_messages_from() to also use index_list_work(), although the
> chance of a monster UPLOAD from a normal append is much lower.
>
> I would prefer sync_index_list_free() to be called in the parent routine
> upload_messages_list() rather than as a side effect to index_list_work(),
> but that is probably just personal style.
Attached is a patch that does both of these :) It's possible that I haven't
done code-path coverage in my limited testing (it's on our test machine) so
a bit of review is probably in order!
Bron.
-- Bron Gondwana
|
|
|