Re: saslauthd locking issues was Re: saslauthd instability with sockets


Subject: Re: saslauthd locking issues was Re: saslauthd instability with sockets
From: Rob Siemborski (rjs3 at andrew dot cmu dot edu)
Date: Wed May 21 2003 - 08:59:53 EDT


On Wed, 21 May 2003, Leena Heino wrote:

> According to Solaris' fcntl man page F_SETLK never sets errno to EINTR,
> but F_SETLKW does.
>
> I think loop should use F_SETLKW instead of F_SETLK to make sure the lock
> is released.

Yes. I agree. Additionally, we need to check rc != 0, since errno is
invalid unless the function returns an error (similar problem in
get_accept_lock).

I'm committing these fixes to CVS.

-Rob

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Rob Siemborski * Andrew Systems Group * Cyert Hall 207 * 412-268-7456
Research Systems Programmer * /usr/contributed Gatekeeper







Hosted Email Solutions

Invaluement Anti-Spam DNSBLs



Powered By FreeBSD   Powered By FreeBSD