From: Kir Kolyshkin (no email)
Date: Mon Apr 15 2002 - 03:44:56 EDT
Patch looks mostly OK, changes to configure stuff are fine.
See my comments below.
Danil Pismenny wrote:
> Here is a patch addes an Interbase SQL backend. It contains all
> needed files include new tables.sql.in that is converted to the
> Interbase syntax.
Can you start this file with uncommented
DROP TABLE IF EXISTS wordurl;
.....
lines? I have already done this for mysql/tables.sql.in file.
> It compiles without errors but the real C-code is
> not implemented yet.
I do not want to apply the part that creates src/ibsqldb.cpp, because
it is just bunch of commented out MySQL driver functions. Having this
in CVS is useless.
I will accept something that at least partially
works and doesn't contain old commented out code.
> Also, there is fixed small syntax bug in configure.in
Committed into CVS
> and all mentions of the "cache" table are renamed to
> "rescache".
Can you create a separate patch for that so I will apply it?
> P.S. Which is right way to make diff if there are new files? "cvs diff
> -N" works if these files are added to the repository only.
You just have to update the sources from CVS, make a copy of it,
apply your patch to that copy (fixing failed hunks manually) and
when do diff -urN between original and patched dirs.
Smth like:
cvs co aspseek
cp aspseek aspseek-my
cd aspseek-my
patch -p1 < dapi.diff
cd ..
diff -urN aspseek aspseek-my > dapi1.diff
ibsqldb.h
------------
Some general notes about your patch:
1. Can you please make sure you use tabs and not 8 spaces for indentation
in your code? I have noticed spaces in tables.sql.in, ibsqldb.h,
aspseek-ib-postinstall.in, ibsqldb.cpp.
2. Please do not create lines larger than 80 chars (I see it in your
configure.in).
-- XMMS: KMFDM - Wrath
|
|
|